search

thlorenz / brace

📔 browserify compatible version of the ace editor.
http://thlorenz.github.io/brace/
MIT License
1.06k stars 304 forks source link

Update worker patch to work with ace 1.9 #109

Closed nightwing closed 6 years ago

nightwing commented 6 years ago

this is based on https://github.com/thlorenz/brace/pull/93

I've only added the last commit https://github.com/thlorenz/brace/commit/7e33fe7ac2034c069d05b6ad52c52680c3c0bc79 which updates the worker patch for the new version of ace, and adds an early for the case when not all lines to replace are found.

thlorenz commented 6 years ago

@nightwing nice, did you make sure the tests still pass?

nightwing commented 6 years ago

yes, i get 

TAP version 13
# error annotations provided by inlined worker
ok 1 javascript editor shows one error
ok 2 on line 5
ok 3 coffee editor shows one error
ok 4 on line 5
ok 5 json editor shows one error
ok 6 on line 5
ok 7 lua editor shows one error
ok 8 on line 6
ok 9 xml editor shows one error
ok 10 on line 5

1..10
# tests 10
# pass  10

# ok

un browser console

thlorenz commented 6 years ago

Thanks, merged and published as v0.11.0