search

thlorenz / brace

📔 browserify compatible version of the ace editor.
http://thlorenz.github.io/brace/
MIT License
1.06k stars 303 forks source link

Please update the underlying ACE implementation #148

Closed StoneCypher closed 5 years ago

StoneCypher commented 5 years ago

Hello and thanks for this high quality library

Would you please bump to 1.4.2? There's some important changes and a language I'd like to pick up.

If you wrote out instructions on how to bump, we could submit bumps for you.

I joined your patreon at $10 to try to motivate you 😃

Please have a good day.

StoneCypher commented 5 years ago

@thlorenz - or if you'd tell us how to do it, I'd do it

tankbusta commented 5 years ago

@StoneCypher Instructions on how to bump the version are included in the README which is what was done in PR #139. Unfortunately, you'll have to fork the repository, bump the version in the updater script, and publish your fork if you want something simple like yarn install brace (unless @thlorenz comes back and automates this process). This is what I did to get 1.4.2

StoneCypher commented 5 years ago

ffffffffffffffffffffffffffffffffffffffffun. (no i use npm because i'm allergic to new things.)

so it's the update script and that's it? cool. thanks, @tankbusta

tankbusta commented 5 years ago

Ha. It doesn't matter if it's yarn or npm, the steps are still the same.

You just need to change update.js to 1.4.2 (or whatever version you want) and run the update script (defined by package.json) with npm run update . Granted I don't use all of (br)ace's functionality but I haven't ran into any issues.

StoneCypher commented 5 years ago

Got it. Thanks again, destroyer of tanks.

https://github.com/thlorenz/brace/pull/151

StoneCypher commented 5 years ago

153