search

thlorenz / brace

📔 browserify compatible version of the ace editor.
http://thlorenz.github.io/brace/
MIT License
1.06k stars 302 forks source link

Upgrade ace editor version to latest #176

Open yadurvt opened 4 years ago

yadurvt commented 4 years ago

Any chance you can upgrade a brace release to align it with ace 1.4.2 ?

trajnisz commented 4 years ago

Current version of Ace is 1.4.10, brace supports 1.2.9. Some 3rd party projects (like integration with angular) uses brace. It would be nice to upgrade

ericuldall commented 4 years ago

Strongly agree. If this project is abandoned it would be nice to know so we can all move on and support something new. Otherwise I think it's reasonable to at the very least keep up with the latest version of ace.

yadurvt commented 4 years ago

I was using ng2-ace-editor angular package. It is integrated with brace but with no latest update I skipped ng2-ace-editor and moved my project to ace-builds 1.4.8, which is also an angular ace package and is updated

trajnisz commented 4 years ago

@yadurvt ace-builds is not an Angular package. It is just the repository used for NPM with generated files in JS. However i`m thinking about creating new Angular wrapper for Ace with all inputs/outputs needed. Now i have beta version working with latest version of Ace (without brace). This repo is dead

yadurvt commented 4 years ago

@trajnisz Have a look at this. Build angular project with ace build. Latest version

https://medium.com/@ofir3322/create-an-online-ide-with-angular-6-nodejs-part-1-163a939a7929

trajnisz commented 4 years ago

@yadurvt Yes, they are using JS library in Angular. This is not the problem, you write like ordinary JS app, but you do not have benefits from Angular. Angular wrappers are ready components/directives that are using JS libraries and enables to use inputs/outputs. For ace-builds info refer to github repo https://github.com/ajaxorg/ace-builds

ericuldall commented 4 years ago

I did similarly, for vue2-ace-editor. Except I decided to build my own plugin using ace-builds. https://npmjs.com/package/@aminoeditor/vue-ace - if anyone else is having an issue with the original vue plugin, this should be a reverse compatible solution.