thlorenz / brace

📔 browserify compatible version of the ace editor.
http://thlorenz.github.io/brace/
MIT License
1.06k stars 304 forks source link

Mismatched / incorrect types #182

Open MysterAitch opened 3 years ago

MysterAitch commented 3 years ago

Hi,

Ace now provides typescript type definitions.

The DefinitelyTyped definitions are out-of-date / incorrect (a specific example is noted within https://github.com/ajaxorg/ace/issues/4404 -- note that the documentation comment, parameter type, and return type are wrong for getMarkers).

Perhaps it would be worth amending the update script to pull from the official types? Or would it be preferable to have the DefinitelyTyped types updated? Or, perhaps, both?