search

thlorenz / brace

📔 browserify compatible version of the ace editor.
http://thlorenz.github.io/brace/
MIT License
1.06k stars 304 forks source link

Fix typo: toggel -> toggle #187

Closed ogajduse closed 2 years ago

ogajduse commented 2 years ago

Fixes #175

thlorenz commented 2 years ago

Please fix in the ace editor itself, this is just a fork that makes it bundleable.

ogajduse commented 2 years ago

Please fix in the ace editor itself, this is just a fork that makes it bundleable.

It seems to be fixed in the ace editor already. Am I looking at the right location? https://github.com/ajaxorg/ace/pull/3437/files#diff-b99eea4f7a1f541de20e5a632387e7c5497b475b25e3f037fec33181107fd9f3L59

ogajduse commented 2 years ago

@thlorenz Can you please point me to the repo which should contain the fix?

thlorenz commented 2 years ago

Sure it's here: https://github.com/ajaxorg/ace

ogajduse commented 2 years ago

Thanks. However, I see that this issue is already fixed there. https://github.com/ajaxorg/ace/blob/master/lib/ace/ext/searchbox.js#L61

Is it sufficient to have it fixed there so the change can be propagated to this repository? What is the process of picking the change from the ajaxorg/ace repository to this repository?

ogajduse commented 2 years ago

@thlorenz Kind reminder on the pending question.

ogajduse commented 2 years ago

@thlorenz ping. I kindly ask for the answer.

ogajduse commented 2 years ago

I am closing the issue due to lacking activity from the repository owner side.