search

thlorenz / browserify-shim

📩 Makes CommonJS incompatible files browserifyable.
MIT License
933 stars 87 forks source link

no longer checking global in 3.8.8 #175

Closed lukemcgregor closed 9 years ago

lukemcgregor commented 9 years ago

Behaviour in 3.8.7

require('underscore') => (typeof window !== "undefined" ? window._ : typeof global !== "undefined" ? global._ : null);

Behaviour in 3.8.8

require('underscore') => (window._);

This is a pretty major breaking change that makes browserify shim not work with server side code.

bendrucker commented 9 years ago

Somehow https://github.com/thlorenz/exposify/commit/0765d033cf5514107b45a192fead7a9a54a76e0d managed to sneak into a release but isn't in master. We recently bumped exposify here and so it disappeared. Will take care of this in a bit and we can cut an exposify patch.

lukemcgregor commented 9 years ago

Awesome :)