search

thlorenz / browserify-shim

📩 Makes CommonJS incompatible files browserifyable.
MIT License
933 stars 87 forks source link

update to a maintained `through`? #249

Open ljharb opened 1 year ago

ljharb commented 1 year ago

Hi! You depend on through, an excellent package that unfortunately has not been maintained since 2018. I've forked it as https://npmjs.com/@ljharb/through so that I can maintain it (with @dominictarr's blessing), and am using it in https://npmjs.com/tape.

Would you be interested in a PR that switches this project to using my fork instead of the original? It's effectively identical, but it'd ensure any vulnerabilities will be addressed in the future.

bendrucker commented 1 year ago

switches inquirer

Assuming this is a copy paste error? But sure this sounds fine happy to merge.

ljharb commented 1 year ago

lol oops, yes, copy-paste error. thanks, i'll make a PR!

valadaptive commented 5 months ago

Just to clarify: the codebases are (as far as I can tell) effectively identical at this time, except for the fact that through has 0 dependencies whereas @ljharb/through has 12 nested dependencies for the purpose of Node 0.4 support. You can decide for yourself whether the extra dependencies are worth the Node 0.4 support, but I think it is important to be transparent.