search

thlorenz / deoptigate

⏱️ Investigates v8/Node.js function deoptimizations.
https://nodesource.github.io/deoptigate-examples/xml2js/01_start/?selectedFileIdx=31&selectedLocation=157&includeAllSeverities=false&highlightCode=true&selectedTabIdx=1&selectedSummaryTabIdx=1
MIT License
1.16k stars 22 forks source link

Streaming read for huge log files (> 1GB) (#18) #20

Closed pbadenski closed 3 years ago

pbadenski commented 3 years ago

Add support for very large files (#18)

pbadenski commented 3 years ago

@thlorenz anything else I can do to help speed up this merge? 😄

pbadenski commented 3 years ago

@thlorenz just following up on the above, is there anything I can do to help getting this pull request through to master?

thlorenz commented 3 years ago

Wow so sorry for not responding earlier. This looks great!

As long as this doesn't break existing functionality I'm fine merging this.

So I made you collaborator.

Please merge to master following this guide. I will then version and publish to npm.

Thanks!

pbadenski commented 3 years ago

Awesome, will do - thanks!

pbadenski commented 3 years ago

Done

thlorenz commented 3 years ago

Awesome, published as 0.6.0, huge 🙏