search

thlorenz / flamegraph

Generates flamegraphs with Node.js or in the browser.
http://thlorenz.github.io/flamegraph/web/
MIT License
165 stars 28 forks source link

Flamegraphs generated with OSX instruments data are incorrect #17

Closed bjouhier closed 6 years ago

bjouhier commented 8 years ago

Flamegraphs generated from instruments CSV files are wrong. For example, with the following CSV file

Running Time,Self,,Symbol Name
100.0ms   100%,0, , foo
50.0ms   50%,0, ,  bar
50.0ms   50%,10, ,   baz
40.0ms   40%,40, ,    zoo
50.0ms   50%,50, ,  qux

I get:

capture d ecran 2016-02-28 a 22 45 36

instead of:

capture d ecran 2016-02-28 a 22 46 02
bjouhier commented 8 years ago

@thlorenz The problem comes from the conversion algorithm in cpuprofilify. I fixed it over there but it needs to be pushed to NPM so that flamegraph picks it up. Would be nice to update the online tool too.

thlorenz commented 6 years ago

Sorry, stopped supporting Instruments callgraphs, soo much easier generated with dtrace directly. More info here.