thlorenz / irish-pub

Feel like npm is drunk or maybe you are and want to verify what gets published via `npm publish`? irish-pub has you covered.

MIT License

69 stars 8 forks source link

determine the tar file name by meta #11

Open chinesedfan opened 7 years ago

chinesedfan commented 7 years ago

10

thlorenz commented 7 years ago

Sorry just saw this. Could you please explain a bit more what this changes and how it works? Hard for me to parse that long replace chain you got there ;)

chinesedfan commented 7 years ago

It's my fault writing such a long chain without comments. I split the chain and update test cases.

According to documents of npm pack, the tarball is named as <name>-<version>.tgz. And for scoped packages, like @scope/package, the name should be converted to be scope-package.

chinesedfan commented 6 years ago

@thlorenz Friendly ping. Can you take a look at this PR?

By the way, if you are too busy, I am glad to be a collaborator, as well as npm maintainer. My npm account is the same, chinesedfan.

thlorenz commented 6 years ago

Sorry for the delay @chinesedfan, I now made you collaborator.

Please merge to master following this guide. I will then version and publish to npm.

Thanks.