test with node-installed npm and include node 6/8

thlorenz / irish-pub

Feel like npm is drunk or maybe you are and want to verify what gets published via `npm publish`? irish-pub has you covered.

MIT License

69 stars 8 forks source link

test with node-installed npm and include node 6/8 #14

Open chinesedfan opened 6 years ago

chinesedfan commented 6 years ago

The latest npm is not compatible with old versions of Node.js. And we should cover new versions of Node.js.

vweevers commented 6 years ago

Might as well add 9 and 10 too. And drop 0.8 and 0.10 if @thlorenz is OK with that.

chinesedfan commented 6 years ago

@vweevers As a new collaborator, I have 2 questions about the collaborator guide, which I also asked in gitter to @thlorenz but I am not sure when he has time to answer.

Can we merge any PR without @thlorenz's agreement? Because he is too busy to check each PR.
Now Github supports squash and merge button. Can we use it directly?

vweevers commented 6 years ago

Can we merge any PR without @thlorenz's agreement? Because he are too busy to check each PR.

I don't know. We'll have to wait for @thlorenz's answer. Note I'm not an active contributor (haven't decided to make that commitment), so you might need @thlorenz anyway.

Now Github supports squash and merge button. Can we use it directly?

Yes.