search

thlorenz / proxyquireify

browserify >= v2 version of proxyquire. Mocks out browserify's require to allow stubbing out dependencies while testing.
MIT License
152 stars 24 forks source link

Support for browserify 5 #12

Closed callum closed 10 years ago

callum commented 10 years ago

Assuming it is currently somehow incompatible.

thlorenz commented 10 years ago

Not sure what your issue is. Does it work for you or not? We may need to update browserify peer dependency. Do you mind submitting a PR with that change which will give you a chance to ensure that it actually does work with the new version?

Thanks.

callum commented 10 years ago

I'm not sure it does work. I changed the peer dependency and also updated the dev dependency to run the test suit, and 80% of them fail.

https://github.com/callum/proxyquireify/commit/00c64aebd48f224789f01f3c6cfd9caaddff7712#diff-d41d8cd98f00b204e9800998ecf8427e

thlorenz commented 10 years ago

Ok, so we need to update the peer dep and fix the tests to work with that and previous browserify versions.

Pulling in @jhiesey since he may know more about this.

jhiesey commented 10 years ago

I'll take a look.

thlorenz commented 10 years ago

Thanks @jhiesey

jhiesey commented 10 years ago

I got something working and will submit a PR soon.

@thlorenz, do you want a patch that makes it work with older versions too, or is only browserify >= 5 fine?