Closed ellbee closed 9 years ago
Could you please provide a description, possibly an example explaining what it fixes. I see the referenced issue, but a quick summary of the problem/solution would be nice.
Otherwise LGTM, pulling in @jhiesey to give his ok as well since he did the last major overhaul.
@thlorenz I've given the explanation a go, let me know if I need to do anything else. Cheers.
Makes more sense now @ellbee, gonna wait for a comment by @jhiesey but LGTM.
I can take a look tonight
Sorry I forgot to look into this. It looks fine to me.
Thanks, went out with 1.1
.
This pull request should enable proxyquireify to work when bundle() is called multiple times on the same browserify instance. This is useful e.g. if you are using watchify to take advantage of its caching facilities for faster builds.
When watchify fires the update event, b.bundle() calls b.reset() which creates a new pipeline. This new pipeline does not contain the browser-pack with the modified prelude that proxyquireify spliced in when the plugin was registered. So all calls to bundle after the first use the standard browserify prelude instead of proxyquireify's.
This pull request splices the proxyquireify browser-pack into the pipeline each time the reset event is emitted by browserify.