search

thlorenz / proxyquireify

browserify >= v2 version of proxyquire. Mocks out browserify's require to allow stubbing out dependencies while testing.
MIT License
152 stars 24 forks source link

Restrict peerDep #30

Closed bendrucker closed 9 years ago

bendrucker commented 9 years ago

proxyquireify does a whole lot more than something like b-shim so it probably shouldn't be a >= peerDep with Browserify. @thlorenz are you cool with switching this to the same policy as b-shim, i.e. >= ${min} < ${currentMajor + 1}?

thlorenz commented 9 years ago

Lets wait tiil we actually get a compat issue. The moment that happens we can fix it and add the peer dep.

bendrucker commented 9 years ago

Fair enough. I'm writing up a tool for doing peerDep major version testing that we can use here and with b-shim for automated testing. I'll do PRs here and for b-shim when it's ready.

thlorenz commented 9 years ago

Awesome, looking forward to that!