search

thlorenz / proxyquireify

browserify >= v2 version of proxyquire. Mocks out browserify's require to allow stubbing out dependencies while testing.
MIT License
151 stars 24 forks source link

proxyquireify not work #56

Closed bokuweb closed 8 years ago

bokuweb commented 8 years ago

Hi! Proxyquireify is nice module. Proxyquireify not work , but it has worked until April 21 2016. I think because the state of the dependent modules has changed?

I use proxyquireify with karma.

...
"karma": "0.13.22",
"proxyquire": "1.7.4",
"proxyquireify": "3.1.1",
...

and karma.conf.js

    browserify: {
      debug: true,
      extensions: ['.js', '.jsx'],
      plugin: ['proxyquireify/plugin'],

and this error occured since yesterday.

22 04 2016 09:17:37.962:ERROR [karma]: [Error: Invalid mapping: {"generated":{"line":79976,"column":15},"source"
:"form-boolean.js","original":{},"name":null}]
Error: Invalid mapping: {"generated":{"line":79976,"column":15},"source":"form-boolean.js","original":{},"name":
null}
    at SourceMapGenerator_validateMapping [as _validateMapping] (/Users/bokuweb/workspace/sample/node_mod
ules/proxyquireify/node_modules/browser-pack/node_modules/combine-source-map/node_modules/inline-source-map/node
_modules/source-map/lib/source-map/source-map-generator.js:275:15)
    at SourceMapGenerator_addMapping [as addMapping] (/Users/bokuweb/workspace/sample/node_modules/proxyq
uireify/node_modules/browser-pack/node_modules/combine-source-map/node_modules/inline-source-map/node_modules/so
urce-map/lib/source-map/source-map-generator.js:105:14)
    at /Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_modules/browser-pack/node_modules/
combine-source-map/node_modules/inline-source-map/index.js:40:15
    at Array.forEach (native)
    at Generator.addMappings (/Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_modules/bro
wser-pack/node_modules/combine-source-map/node_modules/inline-source-map/index.js:38:12)
    at Combiner._addExistingMap (/Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_modules/
browser-pack/node_modules/combine-source-map/index.js:33:18)
    at Combiner.addFile (/Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_modules/browser-
pack/node_modules/combine-source-map/index.js:58:12)
    at Transform.write [as _transform] (/Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_m
odules/browser-pack/index.js:62:23)
    at Transform._read (/Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_modules/browser-p
ack/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:184:10)
    at Transform._write (/Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_modules/browser-
pack/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:172:12)
    at doWrite (/Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_modules/browser-pack/node
_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:237:10)
    at writeOrBuffer (/Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_modules/browser-pac
k/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:227:5)
    at Transform.Writable.write (/Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_modules/
browser-pack/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:194:11)
    at write (/Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_modules/browser-pack/node_m
odules/through2/node_modules/readable-stream/lib/_stream_readable.js:623:24)
    at flow (/Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_modules/browser-pack/node_mo
dules/through2/node_modules/readable-stream/lib/_stream_readable.js:632:7)
    at Transform.pipeOnReadable (/Users/bokuweb/workspace/sample/node_modules/proxyquireify/node_modules/
browser-pack/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:664:5)
npm ERR! Test failed.  See above for more details.

But, iit works when proxyquireify's dependencies update bellow

https://github.com/bokuweb/proxyquireify/blob/master/package.json

  "dependencies": {
    "browser-pack": "6.0.1",
    "detective": "3.1.0",
    "fill-keys": "1.0.2",
    "has-require": "1.2.2",
    "module-not-found-error": "1.0.1",
    "require-deps": "1.0.1",
    "through": "2.3.8",
    "xtend": "4.0.1",
    "duplexer2": "0.1.4"
  },
bendrucker commented 8 years ago

@thlorenz Thoughts on versioning? Might merit a major.

theleon commented 8 years ago

@bendrucker thanks, I got the same problem, it turned out to be fixed in combine-source-map: https://github.com/thlorenz/combine-source-map/commit/42cef13e5fb09b19f6ad390d792c23e487c8b4e6

Any thoughts on when the fix going to be published to NPM?