search

thlorenz / replpad

Pipes content of files to a node repl whenever they change to enable a highly interactive coding experience.
http://thlorenz.github.com/replpad/
MIT License
213 stars 19 forks source link

Fixing issues with atomic saves #18

Closed toddself closed 9 years ago

toddself commented 10 years ago

This fixes #7.

Switching to chokidar for better fs.watch support. Chokidar fixes the issues that the built-in watch has with regards to atomic saves.

I removed the require('path') statement in lib/watcher.js as well since it was unused.

Also, the marked test for dox was failing since marked no longer includes the readme data that is required by the test (fresh node_modules install as of tonight), so I looked in the node_modules directory and saw that xtend provides the correct data, so made the switch to that so that the test cases would succeed.

thlorenz commented 10 years ago

Oh funny, chokidar uses readdirp. I guess we've come full circle :)

So thanks for the PR, so far LGTM and will merge ASAP. Also thanks for fixing the tests.

thlorenz commented 9 years ago

Thanks, went out with 0.13.

toddself commented 9 years ago

Awesome thanks Thorsten!

On Jan 9, 2015, at 2:25 AM, Thorsten Lorenz <notifications@github.com mailto:notifications@github.com> wrote:

Closed #18 https://github.com/thlorenz/replpad/pull/18.

— Reply to this email directly or view it on GitHub https://github.com/thlorenz/replpad/pull/18#event-216367574.