thlorenz / rid

Rust integrated Dart framework providing an easy way to build Flutter apps with Rust.

64 stars 4 forks source link

feat: Windows support in makefiles #35

Closed SecondFlight closed 2 years ago

SecondFlight commented 2 years ago

33

This patch adds Windows support for the Makefiles, while trying to preserve existing behavior on macOS and Linux. There are likely more things wrong, but it's working until the first Windows-related error in rid itself.

Notable changes:

There is now a Makefile.variable file, which is imported by the other Makefiles. This allows variables to be defined once and used anywhere that imports Makefile.variable.
If pub is missing, the script now checks for flutter pub before failing.

SecondFlight commented 2 years ago

Looks like Github Actions is having some issues: https://www.githubstatus.com/incidents/bdbzpz7qxmbx

I tested this using Github Actions on my fork but I've pushed two commits since then, so please double-check that this works locally before merging. Aside from the flutter pub fallback, I expect the behavior to be identical on macOS and Linux.

SecondFlight commented 2 years ago

I can't get workflows to run here, not sure why. My most recent commit passed CI on my fork:

thlorenz commented 2 years ago

Awesome, thanks. I'll have a closer look whenever I've got some time. I'll be traveling all day tomorrow and partially on Thur, so please have some patience. On quick glance though it looks good. I also want to understand the SET_PREFIX thing better so I can answer the question around that.

SecondFlight commented 2 years ago

No worries. Please don't feel any obligation to respond immediately! I certainly don't have any expectations.

I have a lot of time to work on this right now, so my plan is to continue queueing up work on top of the work here. I'll open new PRs as others are merged, but again no rush on anything!

SecondFlight commented 2 years ago

I also want to understand the SET_PREFIX thing better so I can answer the question around that.

My comment was actually on line 19 (17 in the original):

./.dart_tool/:

I tried to search to see if it's a special syntax but I couldn't find anything. It's probably something simple - I'm new to make, so still learning the ropes.

thlorenz commented 2 years ago

Thanks a lot for this one and the other PR as well. I hope this helps you getting things to work in general. I'd love to see one of the rid-examples run on windows .. please send a screenshot if you have one running!

thlorenz commented 2 years ago

BTW I'm not deleting your branches even though they might be no longer needed. Please do so yourself once you're done with them. Thanks!

SecondFlight commented 2 years ago

I'd love to see one of the rid-examples run on windows .. please send a screenshot if you have one running!

Will do!