search

thlorenz / rid

Rust integrated Dart framework providing an easy way to build Flutter apps with Rust.
64 stars 4 forks source link

fix Open Dynamic Library Linux path #46

Closed enzotar closed 2 years ago

enzotar commented 2 years ago

Updated Linux path for generated file rid_api.dart and removed unreachable linux check.

thlorenz commented 2 years ago

Thanks, looks good, did you get a chance to verify that this works on Android or just Linux? Just wondering since the change is in the branch that is for Linux and Android. It could be that this works differently there and we need to actually have a separate branch for Linux vs. Android.

I'll double check this myself before merging if you didn't or cannot check this yourself Just give me a bit time in that case as I'm currently traveling.

thlorenz commented 2 years ago

OK saw in the comment of the issue that you cannot test on Android, no problem. I'll look into it this week (need to connect a physical phone to test this works 100% which I don't wanna do at an airport 😅 ).

thlorenz commented 2 years ago

Hi, sorry for the delay .. I promise to get to it by next week. If not please hold me to it 😄

thlorenz commented 2 years ago

Hey @enzotar, finally got around to testing it and like I suspected Android did not work. I implemented a fix which you could just merge into your branch and then we can merge this PR: https://github.com/thlorenz/rid/commit/384483f5f98a3f494642adeebba4afb47934eee8

Thanks for your patience 😄

thlorenz commented 2 years ago

Thanks now it's perfect 😄