Closed Roms1383 closed 2 years ago
LMK if I forget something, TBH I'm not familiar with Flutter/Dart 🙏
LMK if I forget something, TBH I'm not familiar with Flutter/Dart 🙏
Checks won't run on PRs from forks, but if you open a pull request from (your fork):chore/update-ffigen
to (your fork):master
, it will run checks there. As long as the checks pass then I'm sure it'll be good to merge, since make test
runs ffigen
a bunch of times.
Ah ok let me do this.
Here I guess : https://github.com/Roms1383/rid/pull/1/checks ?
Yeah, that looks right... Not sure why they're not running. Maybe I had enabled actions in settings on my fork and completely forgot I did? https://github.com/Roms1383/rid/settings/actions
Not sure actually, but it looks stuck indeed ^^'
Ok my bad, it had to be enabled in both Actions and Settings apparently, sorry bout that.
Currently running on https://github.com/Roms1383/rid/actions/runs/1355258796
Ok passed @SecondFlight
Ok, awesome, looks good to me then. I'll defer to @thlorenz to merge.
Awesome, thanks!
update ffigen in: