thlorenz / rid

Rust integrated Dart framework providing an easy way to build Flutter apps with Rust.
64 stars 4 forks source link

chore: update ffigen #49

Closed Roms1383 closed 2 years ago

Roms1383 commented 2 years ago

update ffigen in:

Roms1383 commented 2 years ago

LMK if I forget something, TBH I'm not familiar with Flutter/Dart 🙏

SecondFlight commented 2 years ago

LMK if I forget something, TBH I'm not familiar with Flutter/Dart 🙏

Checks won't run on PRs from forks, but if you open a pull request from (your fork):chore/update-ffigen to (your fork):master, it will run checks there. As long as the checks pass then I'm sure it'll be good to merge, since make test runs ffigen a bunch of times.

Roms1383 commented 2 years ago

Ah ok let me do this.

Roms1383 commented 2 years ago

Here I guess : https://github.com/Roms1383/rid/pull/1/checks ?

SecondFlight commented 2 years ago

Yeah, that looks right... Not sure why they're not running. Maybe I had enabled actions in settings on my fork and completely forgot I did? https://github.com/Roms1383/rid/settings/actions

Roms1383 commented 2 years ago

Not sure actually, but it looks stuck indeed ^^'

Roms1383 commented 2 years ago

Ok my bad, it had to be enabled in both Actions and Settings apparently, sorry bout that.

Roms1383 commented 2 years ago

Currently running on https://github.com/Roms1383/rid/actions/runs/1355258796

Roms1383 commented 2 years ago

Ok passed @SecondFlight

SecondFlight commented 2 years ago

Ok, awesome, looks good to me then. I'll defer to @thlorenz to merge.

thlorenz commented 2 years ago

Awesome, thanks!