search

thlorenz / rid

Rust integrated Dart framework providing an easy way to build Flutter apps with Rust.
63 stars 4 forks source link

Missing `linux()` in FlutterPlatform #6

Closed MGlolenstine closed 3 years ago

MGlolenstine commented 3 years ago

There's linux() function missing on FlutterPlatform struct, which is referenced from within the rid-build.rs.

This has been addressed in rid-examples#1. I'd love to make a PR, but I'm unsure how. Should I create a new branch, make changes, push them and make a PR?

lattice0 commented 3 years ago

@MGlolenstine do you have write poermissions? According to @thlorenz, you should make a branch and do the modifications, at least he told me this. I did not have the time to do but would be great if you did

MGlolenstine commented 3 years ago

@lucaszanella I do have write permissions, I was just unsure on what to do, as I haven't done any PRs to repositories that I wasn't supposed to fork... I can make a new branch and make changes, make a PR and change the stuff in the template and root.

thlorenz commented 3 years ago

@MGlolenstine as explained here you do have write permissions since this is the only way to keep this repo private and still have you access the code at all. You should not directly push to this repo though (at least not on master).

Instead please clone it, keeping it private and submit a PR with any changes you aim to make. Basically do it exactly as if you didn't have write permissions except when you are working on your branch.

If you can figure out how to fork it and keep it private that will work as well. If you cannot then feel free to push your changes here on a separate branch prefixed with your username, i.e. , MGlolenstine/mypatch and submit a PR from that branch.

I failed to explain that inside the readme as I'm also figuring these things out as we go.

Thanks.

MGlolenstine commented 3 years ago

Oh, thanks for more info! From the README, I understood like we mustn't fork the repo, but I understand the point of keeping it private.

I don't know how many private repos I have left, though. I will have to test it out!

MGlolenstine commented 3 years ago

A fork of the repository is automatically private, and it doesn't count against your private repositories, so I'm able to keep it private after forking.