search

thlorenz / v8-perf

⏱️ Notes and resources related to v8 and thus Node.js performance
2.2k stars 112 forks source link

How do we provide line by line discussion #2

Closed thlorenz closed 6 years ago

thlorenz commented 10 years ago

@mraleph I thought about what the best way would be to enable you to comment on/correct/add to the material here.

So I squashed all commits into one in order to facilitate a line by line discussion in the the diff. This way we can go back and forth discussing the details if we want.

However I also created a disc-one branch and gave you commit access to the repo, so you can quickly jot down in that branch whatever needs to be added/corrected. I'll sort it out then to pull it into master.

Let me know if this setup works for you or if you prefer another way to contribute. I wanna make this as easy and efficient as possible.

I very much appreciate you taking the time to contribute to help get this information into a good state :)

thlorenz commented 9 years ago

@mraleph I pulled out the actual v8 dox into a separate repo. Now it takes about a second to clone this v8-perf repo - instead of minutes before. It also doesn't pull down 2.5G. Instead now only 664K :)

I hope this makes contributing easier.