Launcher gets an indefinite "Please Wait" dialog when trying to load emulator the first time

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Install Launcher plugin on Dharma Beta 2 Live from addon repo
2. Install zsnes via sudo apt-get install zsnes
3. Go to Launcher and press C for context menu
4. Specify emulator location, rom location and arguments
5. Run Zsnes via launcher and click "yes" when it asks you to import roms
6. You will get a "please wait" dialog that never completes.
7. Verify that there is no .zsnes folder yet created in the home directory
8. Restart the system (because you have to do so)
9. Go back and click Launcher > Zsnes and you get a rom list this time, which 
launch when you click them.

NOTE: This appears to happen on all emulators I have tried, although I'm using 
Zsnes to reproduce it.

What is the expected output? What do you see instead?
I expect a list of Roms to appear after clicking Zsnes, but instead it says 
"Please Wait" indefinitely until I restart my system.

What version of the product are you using? On what operating system?
Dharma Live Beta 2 on a Revo 1600. This was confirmed on 2 boxes. 

Please provide any additional information below.
This was mentioned in the official help/support thread by a few members, so I 
don't think it's an isolated case. My suspicion is that no one will ever see it 
if they already have a /.zsnes/ (or whatever the emulator name may be) in their 
home folder.

Original issue reported on code.google.com by harmon.a...@gmail.com on 6 Oct 2010 at 5:13

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

What do you do if you get the same issue in a windows box? I cant change the 
DIR or emulator anymore. I only have the option to change the search engine 
which doesn't work. 

Original comment by mixingui...@gmail.com on 6 Oct 2010 at 11:12

[GoogleCodeExporter]

Confirming this bug, happened to me as well. (Linux)

Haven't checked if it is just the first launcher you add, or if it happens to 
any launcher. 

Possible workaround could be to open context menu and select import roms from 
path. That was the workaround I used on earlier versions for dharma.

Original comment by eir...@gmail.com on 7 Oct 2010 at 9:25

[GoogleCodeExporter]

Temporary workaround which worked on Linux: (now confirmed)

After adding a Launcher (e.g. Zsnes emulator), instead of pressing enter on 
Zsnes (or similiar), open context menu (c) and select import files from path. 
Should import sucessfully without crashing Launcher.

Original comment by eir...@gmail.com on 7 Oct 2010 at 9:31

[GoogleCodeExporter]

Seems like problem is occurring whenever you add an emulator-type launcher, and 
not just on the first one.

Original comment by eir...@gmail.com on 7 Oct 2010 at 9:33

[GoogleCodeExporter]

So I have semi-solved the problem (not commited though). Again, it looks like 
some kind of timing issue, removing the progressbar made it work on Linux. 

Original comment by eir...@gmail.com on 7 Oct 2010 at 10:09

[GoogleCodeExporter]

I believe I have fixed this, but the fix is really weird.

Line 573: pDialog.close() and it works for me, please test this on other 
systems etc. (I tested on Linux)

Original comment by eir...@gmail.com on 8 Oct 2010 at 6:28

• Added labels: Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

What did you edit on that line of code? I found it on my windows box, but it is 
line 569

Original comment by mixingui...@gmail.com on 8 Oct 2010 at 7:36

[GoogleCodeExporter]

It should contain pDialog.close(), seems like I might have looked upon the 
wrong version.

It's the last reference to pDialog.close() (of 2) in the function def 
_import_roms(self, launcherName, addRoms = False):

Original comment by eir...@gmail.com on 8 Oct 2010 at 9:39

[GoogleCodeExporter]

actually looking at the launcher directly from repo it should be line 573

Original comment by eir...@gmail.com on 8 Oct 2010 at 9:45

[GoogleCodeExporter]

Comment that line out(place # at the beginning of the line) or delete it.

Original comment by eir...@gmail.com on 8 Oct 2010 at 9:46

[GoogleCodeExporter]

Check trunk source for example:
http://code.google.com/p/xbmc-launcher/source/browse/trunk/plugin.program.launch
er/resources/lib/launcher_plugin.py

Original comment by eir...@gmail.com on 8 Oct 2010 at 9:50

[GoogleCodeExporter]

Issue 37 has been merged into this issue.

Original comment by eir...@gmail.com on 17 Oct 2010 at 6:32

[GoogleCodeExporter]

Why is 37 merged? If I have all my roms in one folder it works. It is just if 
they are in sub-directories.

Original comment by parker.l...@gmail.com on 18 Oct 2010 at 2:23

[GoogleCodeExporter]

Original comment by eir...@gmail.com on 18 Oct 2010 at 2:23

• Changed state: Started

[GoogleCodeExporter]

Any update on this? I find it really odd that a program in the official XBMC 
repos has a bug this large, especially for an action that it's most commonly 
used to perform.

Original comment by harmon.a...@gmail.com on 4 Jan 2011 at 5:28

[GoogleCodeExporter]

The reason there haven't really been any new release to launcher is because I 
believed advanced launcher should take over for launcher in the official repo, 
but I don't know if that has been decided or not.

If you want to quick fix it just replace your launcher_plugin.py with this:
http://code.google.com/p/xbmc-launcher/source/browse/trunk/plugin.program.launch
er/resources/lib/launcher_plugin.py

Original comment by eir...@gmail.com on 4 Jan 2011 at 5:31

[GoogleCodeExporter]

Understandable. And that's for link.

The problem with Advanced Launcher is that (and I may be missing something 
simple), there's no way to skip the long tedious import process for your 
content. I believe it scrapes your roms no matter what you do, so if you have a 
folder of 800 NES roms or whatever, you better go take a lunch break or two (or 
three... or four). Launcher does a quick scan and is therefore better for large 
libraries.

Original comment by harmon.a...@gmail.com on 4 Jan 2011 at 5:35

[GoogleCodeExporter]

Wow, I must have not been paying attention in my last post. I meant to say 
"thanks for the link". Not sure what happened there...

Original comment by harmon.a...@gmail.com on 4 Jan 2011 at 6:30

[GoogleCodeExporter]

Original comment by eir...@gmail.com on 21 Mar 2011 at 9:24