search

thmsbfft / oryoki

Ōryōki [応量器] is an experimental web browser with a thin interface.
http://oryoki.io/
MIT License
484 stars 32 forks source link

Error when closing #10

Closed arkag closed 8 years ago

arkag commented 8 years ago

Clicking red "close" button results in the following pop up.

Uncaught Exception:
TypeError: Cannot read property 'close' of null
    at Oryoki.closeWindow (/Users/ishmael/Downloads/Archives/Oryoki.app/Contents/Resources/app/main.js:1301:20)
    at emitOne (events.js:96:13)
    at EventEmitter.emit (events.js:188:7)
    at EventEmitter.<anonymous> (/Users/ishmael/Downloads/Archives/Oryoki.app/Contents/Resources/electron.asar/browser/api/web-contents.js:156:13)
    at emitTwo (events.js:106:13)
    at EventEmitter.emit (events.js:191:7)

What information do you need from me?

thmsbfft commented 8 years ago

What OS version are you on? And, does this happen after launching the app, closing the first window or after having opened/closed several? I'll look into it.

On Thu, Jun 30, 2016, 7:57 AM Alex Roberts notifications@github.com wrote:

Clicking red "close" button results in the following pop up.

Uncaught Exception: TypeError: Cannot read property 'close' of null at Oryoki.closeWindow (/Users/ishmael/Downloads/Archives/Oryoki.app/Contents/Resources/app/main.js:1301:20) at emitOne (events.js:96:13) at EventEmitter.emit (events.js:188:7) at EventEmitter. (/Users/ishmael/Downloads/Archives/Oryoki.app/Contents/Resources/electron.asar/browser/api/web-contents.js:156:13) at emitTwo (events.js:106:13) at EventEmitter.emit (events.js:191:7)

What information do you need from me?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/thmsbfft/oryoki/issues/10, or mute the thread https://github.com/notifications/unsubscribe/AFBmlWHGgt4-BSMAmPvNIw3Ap5kyZlP8ks5qQ9klgaJpZM4JCP8U .

arkag commented 8 years ago

Seems to be after opening and closing several. I opened 4 and then closed 3 without issue. The original window threw the error. The original window closed after some time of sitting, too.

arkag commented 8 years ago

Just reproduced, and realized I forgot to tell you my OS version: 10.11.5

Side note: CMD-W closes all without issue.

thmsbfft commented 8 years ago

Gotcha. Good catch. I'm emulating the system traffic lights so that's probably something related.

arkag commented 8 years ago

What do you mean by emulating them? Not well versed in development, especially in regards to Apple software.

thmsbfft commented 8 years ago

I'm not using the system's traffic lights, just creating a bunch of buttons and wiring them to the close() minimize() fullscreen() hooks that Electron provides (that's so I can hide/show the entire title bar) – meaning I have to handle windows myself, which obviously I didn't do 100% right, ah!