search

thmsbfft / oryoki

Ōryōki [応量器] is an experimental web browser with a thin interface.
http://oryoki.io/
MIT License
484 stars 32 forks source link

Hide status on hover #39

Closed jondashkyle closed 6 years ago

jondashkyle commented 6 years ago

This enables a preference to be hide the status when hovering over links. Alternatively, this could check to see if the href is linking to another domain, and if so display the status, otherwise hide.

Personally find this fading in and out frequently to be a distraction. On mobile, where you don’t have hover states, this functionality doesn’t exist, and doesn’t feel like a security risk.

Side note, I tried adding a comment to the preferences.json consistent with the established formatting convention (//), but it throws an error about malformed JSON. Weird!

thmsbfft commented 6 years ago

Agree, that behavior can be jarring. Why not call that preference item show_url_preview (set to true by default)?

Otherwise PR looks fine to me, will just have to update model_version for the next public release so older clients are prompted to update their preferences.

About that side note: could you attach the preferences.json file where the error occurs? My regex to strip the comments might not be matching soft tabs or a rogue character.

jondashkyle commented 6 years ago

Makes sense to me! Soft tabs was the issue; you can replicate quite easily.

thmsbfft commented 6 years ago

Merged, thanks! 👌
Will have a look at that soft tab issue, too.