search

thobach / MMM-Gestures

MMM-Gestures is a head-less 3rd party module for MagicMirror that allows to control the Magic Mirror via gestures of two types of infrared sensors. Use cases include presence awareness to trigger compliments or go into sleep mode and scrolling through news tickers or view news details.
http://blog.thomas-bachmann.com/2016/02/magic-mirror-2-0-mit-gestensteuerung.html
42 stars 12 forks source link

Modules not responding to Gestures after Update MM / fresh install #18

Closed SaschaSp closed 2 years ago

SaschaSp commented 2 years ago

After Update to MagicMirror 2.19.0 News& Compliments not responding to Gestures. Try a fresh install from MMM-Gestures & also MagicMirror, same behavior. Checked that /dev/ttyUSB0 within node_helper.js set right. Sensors are working, checked with screen /dev/ttyUSB0 9600. pm2 logs shows: 0|MagicMirror | [04.04.2022 13:10.44.503] [ERROR] 0|MagicMirror | TypeError: SerialPort is not a constructor 0|MagicMirror | at /home/pi/MagicMirror/modules/MMM-Gestures/node_helper.js:117:25 0|MagicMirror | at ChildProcess.exithandler (node:child_process:397:7) 0|MagicMirror | at ChildProcess.emit (node:events:390:28) 0|MagicMirror | at maybeClose (node:internal/child_process:1064:16) 0|MagicMirror | at Socket. (node:internal/child_process:450:11) 0|MagicMirror | at Socket.emit (node:events:390:28) 0|MagicMirror | at Pipe. (node:net:687:12)

Tom-Hirschberger commented 2 years ago

Hi, had the same issue with my module (Thank you @SaschaSp; Would not have noticed without you contacting me and creating this issue). The syntax of the declaration of SerialPort and ReadLineParser changed. I opened an pull request which should fix the issue.

19

thobach commented 2 years ago

Should be resolved now thanks to the fix from @Tom-Hirschberger.

SaschaSp commented 2 years ago

Working great again, Thanks @Tom-Hirschberger and @thobach