search

thobbs / phpcassa

PHP client library for Apache Cassandra
thobbs.github.com/phpcassa
MIT License
248 stars 78 forks source link

Fix estrict supercolumnfamily #104

Closed ricardclau closed 12 years ago

ricardclau commented 12 years ago

This is an attempt to remove E_STRICT errors regarding SuperColumnFamily being extended from ColumnFamily, should fix #102

BTW, I am not able to run the test suite, I installed Cassandra 0.8.2 in PHP 5.4.8 and I get these errors:

Fatal error: Class 'phpcassa\Batch\CfMutator' not found in /datos/personal/phpcassa/lib/phpcassa/ColumnFamily.php on line 694

However it seems class is properly included... so I cannot check if everything works as expected, will try at work tomorrow

ricardclau commented 12 years ago

Ping? Is the pull request ok? Do you want me to change something?

adios3333 commented 12 years ago

Hi, I have the same problem. I'll try your fix, and let you know.

thobbs commented 12 years ago

Sorry for the delay, I just didn't have a good chance to review this until now.

thobbs commented 12 years ago

Looks great! Thanks for taking care of this.

ricardclau commented 12 years ago

No problem man! Thanks to you for mantaining and improving the library!

BTW do you know what may happen with the unit tests? Are you able to run them? To which version of Cassandra are you trying the operations?

thobbs commented 12 years ago

I am able to run the unit tests just by running phpunit in the top-level directory. I'm running against Cassandra 1.1.6. I would expect there to be problems with Cassandra 1.2 or trunk due to the switch to the Murmur3Partitioner.

Also, some of the tests will fail when using RandomPartitioner instead of ByteOrderedPartitioner, because they depend on keys being in sorted order. I've been meaning to add a check and skip for those tests, but haven't gotten around to it yet.

ricardclau commented 12 years ago

I am having a problem with Fatal Error: Class 'phpcassa\Batch\CfMutator' not found when I run the tests

Doesn't seem to be a problem with Cassandra but with autoloading so maybe there is some issue with PHP5.4 or something like this. If it is ok to you I will look deeper into it and come back if I find some incompatibility with the new PHP versions

Also, if it is ok to you I might try to configure a travis.yml file so you can get the library automatically tested with PHP5.3, 5.4 and some different Cassandra versions

Anyway, again, thanks for the great work on this!

thobbs commented 12 years ago

Doesn't seem to be a problem with Cassandra but with autoloading so maybe there is some issue with PHP5.4 or something like this. If it is ok to you I will look deeper into it and come back if I find some incompatibility with the new PHP versions

Hmm, interesting. It might be a problem with some versions of phpunit, as well. I'm using phpunit 3.6.10, and php 5.3.6, for what it's worth. Feel free to open another issue if you can narrow it down any.

Also, if it is ok to you I might try to configure a travis.yml file so you can get the library automatically tested with PHP5.3, 5.4 and some different Cassandra versions

That would be great! Let me know how I can help.

Anyway, again, thanks for the great work on this!

No problem at all :)

ricardclau commented 12 years ago

Hi!

Just a quick update on my travis testing

Using PHP 5.3.18 and 5.4.8 (current latest) it crashes in travis exactly as it happens to me. You can see them "crashing" at https://travis-ci.org/ricardclau/phpcassa

I will do another build just with 5.3.6 and Cassandra 1.1 and see if it passes.

Meanwhile... are you sure you don't have any special php.ini settings or include files or stuff like this?

Best regards!