thobbs / phpcassa

PHP client library for Apache Cassandra
thobbs.github.com/phpcassa
MIT License
248 stars 78 forks source link

CfMutator fixing #120

Closed nmmmnu closed 11 years ago

nmmmnu commented 11 years ago

CfMutator restructuring:

thobbs commented 11 years ago

CfMutator does not extend Mutator because the method signatures for insert() and remove() are different between the two classes. With strict checking enabled, PHP does not like this.

I'm not sure what you mean about send(). Can you clarify that?

nmmmnu commented 11 years ago

well cf mutator does not work in the way it is at the moment, because send() did not submit anything , e.g. mutation list is empty.

either send must be rewritten to call send() of "sub object" or insert and remove must be rewritten in the way I made pull request for them.

PHP Strict Standards - I suspected so, but did not know that I need to have error_reporting(E_ALL | E_STRICT); instead of just E_ALL.

then possible solution will be to merge AbstractMutator and Mutator, then to made empty AbstractMutator class with just send() method, and both of the classes to extend it - will do so and will resubmit it as pool request so you can check it.

nmmmnu commented 11 years ago

pls close / reject this pull reuest, i am making another fix