search

thobbs / phpcassa

PHP client library for Apache Cassandra
thobbs.github.com/phpcassa
MIT License
248 stars 78 forks source link

Upgrade travis.yml for php5.5 and thrift_extension #133

Closed ricardclau closed 11 years ago

ricardclau commented 11 years ago

Hi

I think we should start testing phpcassa with php5.5 and get rid of the 5.3.2 version (5.3 has reached its end of life) and just test latest 5.3 versions.

Also, there are repos like Twig (https://github.com/fabpot/twig) that launch tests both with and without the PHP extension compiled. I think this would be a nice addition to all these test suite and perhaps make that more and more people use the extension

Are you :+1: on that? I can work on a quick PR to add this stuff

thobbs commented 11 years ago

I agree 100%, that sounds great. If you open a PR I'll review it quickly and get it merged in. Thanks!

thobbs commented 11 years ago

Closing since this was handled by #134

nmmmnu commented 11 years ago

I think, we need to keep 5.3 compatibility. Lots of people still use even 5.2, because it is not 100% compatible with 5.3 On Jul 29, 2013 7:38 PM, "Tyler Hobbs" notifications@github.com wrote:

I agree 100%, that sounds great. If you open a PR I'll review it quickly and get it merged in. Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/thobbs/phpcassa/issues/133#issuecomment-21732683 .

thobbs commented 11 years ago

@nmmmnu the fact that php 5.3 is now well into its end of life cycle is a strong argument for dropping support for it. phpcassa users can always continue using previous versions of the library while they are on php 5.2/5.3.

A note about 5.3 EOL in the 5.3.20 release notes:

Please note that the PHP 5.3 series will enter an end of life cycle and receive only critical fixes as of March 2013. All users of PHP are encouraged to upgrade to PHP 5.4.