Don't modify internal state of array when it's passed by value

thobbs / phpcassa

PHP client library for Apache Cassandra

thobbs.github.com/phpcassa

MIT License

248 stars 78 forks source link

Don't modify internal state of array when it's passed by value #82

Closed lafka closed 12 years ago

lafka commented 12 years ago

array_shift(); changes the original array and triggers E_NOTICE warning. The array's internal pointer is already on the first position so current(); can be used instead.

thobbs commented 12 years ago

Awesome, thanks!

I see you did the right thing with the pull request on this one :)