thobbsinteractive / magic-carpet-2-hd

Recode Binary code of game Magic Carpet2 to C/C++ language(remake MC2 for any platform)
GNU General Public License v3.0
27 stars 4 forks source link

add support for generic joysticks #234

Closed rodan closed 1 year ago

rodan commented 1 year ago

joystick implementation that works by changing the in-game mouse structures

what works:

tell me what you think.

cheers, peter

thobbsinteractive commented 1 year ago

Thanks Pete. I will test it when I can and then see what can be done about the main menu. I have a few things on atm, but I should have it tested on/by the weekend. Scaling the Menus is difficult because the selection logic and render logic are in completely different places in the code (It makes me actually miss working with Windows Forms). We also have the problem that with a software render scaling the icons would be difficult. (obviously 2x bigger would be easy).

rodan commented 1 year ago

I see. okay then, I think I will add an extra argument to VGA_Set_mouse() that will help identify the scene and make the pointer know it's actual max_x,max_y coords and if it's expected to navigate a menu or fly (so pressing CTRL will only be needed when you want to open the spellbook). that would be a simple fix until there's a graphical overhaul like switching to opengl. I'll keep you posted.

thobbsinteractive commented 1 year ago

Cool. I have no problem with extra parameters as long as they are optional. Tom disliked any extra parameters I created (e.g. for rendering menus etc...) and actually changed them back to global variables. So I kind of came to a compromise of making most parameters optional or overloading methods with the parameterless methods using the globals.

Just do you know, I will always intend to keep the software render, just because some people like it and it is a bit of gaming history.

On Wed, 12 Apr 2023, 05:25 Petre Rodan, @.***> wrote:

I see. okay then, I think I will add an extra argument to VGA_Set_mouse() that will help identify the window and make the pointer know it's actual max_x,max_y coords and if it's expected to navigate a menu or fly (so pressing CTRL will only be needed when you want to open the spellbook). that would be a simple fix until there's a graphical overhaul like switching to opengl. I'll keep you posted.

— Reply to this email directly, view it on GitHub https://github.com/thobbsinteractive/magic-carpet-2-hd/pull/234#issuecomment-1504521935, or unsubscribe https://github.com/notifications/unsubscribe-auth/AETQQFCBI3FRPELZVPUR4CDXAYOCRANCNFSM6AAAAAAWZNXEXA . You are receiving this because you commented.Message ID: @.***>

rodan commented 1 year ago

updates are only provided on https://github.com/thobbsinteractive/magic-carpet-2-hd/pull/235 closing this one