search

thobbsinteractive / magic-carpet-2-hd

Recode Binary code of game Magic Carpet2 to C/C++ language(remake MC2 for any platform)
GNU General Public License v3.0
27 stars 4 forks source link

patch: GameRenderHD random crash during pointer dereference #243

Closed rodan closed 1 year ago

rodan commented 1 year ago

I've noticed that during the crash that *v165 which is used as an array index later on was -1. so this is either a wrong int type, recode conversion error or an original game bug.

tested this patch for a few hours now @1024x768 and not one crash.

joystick change is unrelated, can't remove it.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

1024x768 commented 1 year ago

ahem

rodan commented 1 year ago

looks like I woke up someone =)