search

thoemmi / TinyLittleMvvm

A small MVVM library for WPF built on top of MahApps.Metro, supporting .NET Framework >= 4.7.2 and .NET Core >= 3
MIT License
132 stars 22 forks source link

Position="Left"? #10

Closed ALndrew closed 6 years ago

ALndrew commented 6 years ago

Hi there - enjoying the project! Hopefully a simple question, but adding Position="Left" to the Flyout control does not make the control appear from the left. Is there a way to do this?

Thanks, Andrew

thoemmi commented 6 years ago

You're right, currently the position is hard-coded in FlyoutManager.

Maybe I change the code so that the position is not set if the view is a Flyout. I'll think about it.

thoemmi commented 6 years ago

I've added an optional parameter Position to all overrides of IFlyoutManager.ShowFlyout. Please check the latest build 0.6.0-unstable0005.

alexmurari commented 6 years ago

@thoemmi, there's an error in your implementation: you´ve declared the parameter 'position' in the ShowFlyoutInternal method, but you never use it. The flyout position is still hardcoded.

https://github.com/thoemmi/TinyLittleMvvm/blob/4120298feffe2b5d357a146b7041178077c152ce/src/TinyLittleMvvm/FlyoutManager.cs#L37

thoemmi commented 6 years ago

🤦‍♂️ D'oh, you're right. Fixed with 5644bb8101aad342570f6278a145a613f8845c21, Please try 0.6.0-unstable0006.