search

thoemmi / TinyLittleMvvm

A small MVVM library for WPF built on top of MahApps.Metro, supporting .NET Framework >= 4.7.2 and .NET Core >= 3
MIT License
132 stars 22 forks source link

Remove local LibLog.cs since using nuget-package #11

Closed snakefoot closed 5 years ago

snakefoot commented 5 years ago

https://github.com/thoemmi/TinyLittleMvvm/blob/d933d0bcb365c5d94275ef915905cfaeb5d6afc2/src/TinyLittleMvvm/App_Packages/LibLog.4.2/LibLog.cs#L4

thoemmi commented 5 years ago

fixed in 23d52778

snakefoot commented 5 years ago

@thoemmi Remember to add PrivateAssets="All":

https://github.com/thoemmi/TinyLittleMvvm/blob/50af7c8e6395503131acb26548429f8226023dcc/src/TinyLittleMvvm/TinyLittleMvvm.csproj#L46

thoemmi commented 5 years ago

No need too, GitVersionTask is marked as development dependency:

https://github.com/GitTools/GitVersion/blob/8e23b5b4878c254f2af754f2aabc704a42c4dc35/src/GitVersionTask/GitVersionTask.csproj#L22

snakefoot commented 5 years ago

Neat if it works. More should use it

Sent from my Sony Xperia

---- Thomas Freudenberg wrote ----

No need too, GitVersionTask is marked as development dependency:

https://github.com/GitTools/GitVersion/blob/master/src/GitVersionTask/GitVersionTask.csproj#L22

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/thoemmi/TinyLittleMvvm/issues/11#issuecomment-444267298, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK-fnJvbS_HKWuKLdaBVe34UkBxwqCiTks5u1uqGgaJpZM4Yp__E.

thoemmi commented 5 years ago

Had to force push because of a GitVersion issue. I have also added .NET 4.6 and 4.7 to target frameworks. Version 0.6.0-unstable0008 should be available on NuGet.org in a couple of minutes.