search

thoemmi / TinyLittleMvvm

A small MVVM library for WPF built on top of MahApps.Metro, supporting .NET Framework >= 4.7.2 and .NET Core >= 3
MIT License
132 stars 22 forks source link

The WindowManager is missing ShowDialog #31

Closed ahmediddma closed 4 years ago

ahmediddma commented 5 years ago

The WindowManager class is missing Window.ShowDialog(); Method

thoemmi commented 4 years ago

Can't you just inject IDialogManager and call its ShowDialogAsync method?

ahmediddma commented 4 years ago

Can't you just inject IDialogManager and call its ShowDialogAsync method?

IDialogManager is used to show the equivalent of the MessageBox in MahApps not windows also i think it even doing that wrong it gets the first MetroWindow from the current opened windows in show the message in it and not in the windows it suppose to show at

thoemmi commented 4 years ago

Ok, I see your point. It's not about dialogs, but to show modal window, right? I'll review your PR.

thoemmi commented 4 years ago

Fixed in 1605508a02c264ff54ee60da9be228ac66a13a42