search

thoemmi / TinyLittleMvvm

A small MVVM library for WPF built on top of MahApps.Metro, supporting .NET Framework >= 4.7.2 and .NET Core >= 3
MIT License
131 stars 22 forks source link

Move mahapps #40

Closed ahmed-abdelrazek closed 3 years ago

ahmed-abdelrazek commented 3 years ago

after https://github.com/thoemmi/TinyLittleMvvm/pull/39

Moved all MahApps Dependencies from the main project to a separate one so the main mvvm project can be used with any wpf project without the need to install Mahapps i hope to reflect that in the nuget package the main one without mahapps and another with the Mahapps compatibility library

thoemmi commented 3 years ago

Thanks for your effort, but I don't see the point. I wrote this library to make it easy to use MahApps.Metro in a MVVM-friendly way, espacially dialogs and flyouts. Without MahApps, there wouldn't be much left except a basic ViewLocator and PropertyChangedBase.

ahmed-abdelrazek commented 3 years ago

@thoemmi and it's still do that the base library is very good at starting new wpf projects with mvvm and ioc etc with this configurtion it will allow developers (and me) to use it for that quickly without forcing them to add unnecessary libraries and if they still need the MahApps.Metro support they can still get it with the extension library for it

thoemmi commented 3 years ago

I see your point, but it would be a big breaking change. Let me think about it whether it's worth it.

ahmed-abdelrazek commented 3 years ago

take your time

thoemmi commented 3 years ago

take your time

Ok, in fact it took me some month :wink: I've moved MahApps.Metro related types to a separate package, TinyLittleMvvm.MahAppsMetro.

I've also changed how viewmodels and views are registered in the service collection. Documentation is missing though, but you can get the idea in the PR #41

ahmed-abdelrazek commented 3 years ago

thank you

thoemmi commented 3 years ago

The PR is now merged and available as prerelease. Thanks for your effort, much appreciated!