search

thoemmi / TinyLittleMvvm

A small MVVM library for WPF built on top of MahApps.Metro, supporting .NET Framework >= 4.7.2 and .NET Core >= 3
MIT License
131 stars 22 forks source link

Latest MahApps unsupported #7

Closed ExVeGi closed 6 years ago

ExVeGi commented 6 years ago

Hello, MahApps 1.6.0.0 is unsupported, will it be updated?

punker76 commented 6 years ago

@ExVeGi what no do you mean with unsupported? Which version?

ExVeGi commented 6 years ago

The alpha version, it's not a full release, will tinylittlemvvm support it after full release or even while in alpha?

punker76 commented 6 years ago

@ExVeGi Which alpha?

ExVeGi commented 6 years ago

@punker76 NuGet unstable version - 1.6.0-alpha0184

punker76 commented 6 years ago

@thoemmi It really doesn't work with v1.6 (pre-release), caused by these lines in csproj

    <Reference Include="System.Windows.Interactivity, Version=4.5.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
      <HintPath>..\packages\MahApps.Metro.1.3.0\lib\net45\System.Windows.Interactivity.dll</HintPath>
      <Private>True</Private>
    </Reference>

2018-01-31_08h39_37

This could be solved e.g. with the paket manager which doesn't add the version informations...

    <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.5'">
      <ItemGroup>
        <Reference Include="MahApps.Metro">
          <HintPath>..\packages\MahApps.Metro\lib\net45\MahApps.Metro.dll</HintPath>
          <Private>True</Private>
          <Paket>True</Paket>
        </Reference>
      </ItemGroup>
    </When>
ExVeGi commented 6 years ago

@punker76 I've fixed it for myself, thanks. @thoemmi it would be useful if it was implemented in the nuget package.

thoemmi commented 6 years ago

IIRC another issue is that TinyLittleMvvm is currently built for MahApps.Metro 1.3, which is strong-named, but starting with 1.6 MahApps.Metro isn't strong-named anymore. Anyway, this week I'm busy, so I hope to address this issue next weekend. Nevertheless, there will be new release of TinyLittleMvvm once MahApps.Metro 1.6 is released.

ExVeGi commented 6 years ago

Just a reminder, don't forget about Autofac 4.6.2, it is out.

Kamdzy commented 6 years ago

8 Should do the work

thoemmi commented 6 years ago

I have uploaded a new unstable release, see https://www.nuget.org/packages/TinyLittleMvvm/0.6.0-unstable0003 (it's in NuGet's queue for validation at the moment).

I also used the opportunity for some housekeeping, i.e. I cleaned up the build process and updated the projects to the new csproj SDK format, see 640be8f2b03ac84260c75c466f9a566367df47e5.

Thanks to @Kamdzy for his contribution!

@ExVeGi Could you please check if the new package works?

ExVeGi commented 6 years ago

Tested, confirmed working. Thank you.