thoglu / jammy_flows

A package to describe amortized (conditional) normalizing-flow PDFs defined jointly on tensor products of manifolds with coverage control. The connection between different manifolds is fixed via an autoregressive structure.
MIT License
42 stars 3 forks source link

Exact coverage calculation fails in the self.coverage_and_or_pdf_scan method #6

Open jvaracarbonell opened 2 weeks ago

jvaracarbonell commented 2 weeks ago

When exact_coverage_calculation is set to true, an error occurs because the number of pdf_evals obtained from get_multiresolution_evals does not correspond to a fixed number of pixels associated with a given nside in HEALPix. This results in an error, as seen.

thoglu commented 2 weeks ago

can you use a workaround for now? I have this function fixed in a version on my local machine, but it is not pushed yet

jvaracarbonell commented 2 weeks ago

Yes, I think I fixed it by parsing sample_points=eval_positions here. However, I now get a different error: AttributeError: module 'jammy_flows.helper_fns.contours' has no attribute 'find_closest_contour'. Due to this. Do you know if that function might have a different name in the GitHub version?