search

tholman / github-corners

A fresher "Fork me on GitHub" callout.
http://tholman.com/github-corners
MIT License
4.93k stars 193 forks source link

SVG animation isn't working in Safari #17

Closed cornellsteven closed 8 years ago

cornellsteven commented 8 years ago

I'll be honest, I don't know a lot about SVG compatibility, so this might be a known thing, but the animation is not working in Safari for me, but works fine in Chrome. I'm on Safari 8.0.6.

tholman commented 8 years ago

To do with vendor prefixes, I'd say. I left them out to be forward facing... but should perhaps put them in :/

cornellsteven commented 8 years ago

I suppose it depends on how much extra code it adds. The little tail wag is great, but maybe not important enough for bloat. That said, I am on the newest version of Safari (for Yosemite, at least), so it might not be a bad idea.

tholman commented 8 years ago

I think you're right... should probably add it!

tholman commented 8 years ago

Ahh, just looked through it all. Going to pass on this one, and look forward. Would involve having @-webkit-keyframes as well as the animations.

I think if people decide that they can't do without it, they can add it in themselves.

Tough call, really. But I feel like this is ok :)

Thanks for pointing it out!

cornellsteven commented 8 years ago

Yeah, that makes total sense. Good call. Thanks for looking into it!

MikeRalphson commented 7 years ago

Just a note probably the same issue on Microsoft Edge.

tholman commented 7 years ago

Actually, since 2015, support for keyframes has gone native. Safari works, and edge should work too. (http://caniuse.com/#feat=css-animation)

MikeRalphson commented 7 years ago

Sorry didn't realise the issue was so old! Will check if there's any reason not working in Edge for me.