search

tholman / github-corners

A fresher "Fork me on GitHub" callout.
http://tholman.com/github-corners
MIT License
4.93k stars 195 forks source link

add z-index #20

Closed calvinmetcalf closed 8 years ago

calvinmetcalf commented 8 years ago

adds a z-index so it will be properly above everything on the page

calvinmetcalf commented 8 years ago

see example with z-index set here without z-index it ends up under the map

tholman commented 8 years ago

Appreciate this... I'm kind of following loosely the same code the original ribbons used - https://github.com/blog/273-github-ribbons ... I don't really think its fair to inject a 9999 z index on someones page (when they may have their own system of doing things)

Going to be a little rash, and say anyone who puts the corner in there, and can't see why its appearing below their content, will be clever enough to add in their own index.

Thanks though!

calvinmetcalf commented 8 years ago

you might be overestimating the general public's experience with css as I'm not a new comer to html but am embarked to say I had to look up in the old version how they got it to appear above the map. So maybe a note above that in the docs would be a good idea.

I'd also be somewhat curious about what kind of issues injecting a 9999 z index could cause on a page.

mkody commented 8 years ago

I'd also be somewhat curious about what kind of issues injecting a 9999 z index could cause on a page.

@calvinmetcalf An exemple: If I put a Lightbox showing some pictures on my page, it's nice to have the ribbon behind the Lightbox and not having the ribbon go by itself in front of everything.

calvinmetcalf commented 8 years ago

Ah right or if you have a bootstrap model open that makes sense thanks

On Mon, Nov 23, 2015, 5:09 PM Kody notifications@github.com wrote:

I'd also be somewhat curious about what kind of issues injecting a 9999 z index could cause on a page.

@calvinmetcalf https://github.com/calvinmetcalf An exemple: If I put a Lightbox https://en.wikipedia.org/wiki/Lightbox_(JavaScript) showing some pictures on my page, it's nice to have the ribbon behind the Lightbox and not having the ribbon go by itself in front of everything.

— Reply to this email directly or view it on GitHub https://github.com/tholman/github-corners/pull/20#issuecomment-159082166 .