Improve color managemente more DRY

tholman / github-corners

A fresher "Fork me on GitHub" callout.

http://tholman.com/github-corners

MIT License

4.93k stars 193 forks source link

Improve color managemente more DRY #3

Closed elrumordelaluz closed 8 years ago

elrumordelaluz commented 8 years ago

Thanks to currentColor variable and global fill it is possible to mantaint the same paths and manage color directly from the parent svg elemente, assigning fill and color. Those will be applied on background and cat respectively.
pen with examples: http://codepen.io/elrumordelaluz/pen/XmygWX/

tholman commented 8 years ago

Cheers.

I added back in the  etc comments (they help me a bit!).

And also changed the url to - https://your-url rather than the #0 you added.

Love the dry changes though :)

elrumordelaluz commented 8 years ago

Sure! I'm sorry about the "massive" markup change. I wrote a jade mixin instead of find/replace and (still) didn't know how to print the color variable in html rendered comments. Also removed the units in css' when value is zero.

Cool stuff as always @tholman !

tholman commented 8 years ago

No worries man, definitely great changes! :dancer:

Appreciate it big time :D