The hitbox for the link is a square, not a triangle

tholman / github-corners

A fresher "Fork me on GitHub" callout.

http://tholman.com/github-corners

MIT License

4.93k stars 193 forks source link

The hitbox for the link is a square, not a triangle #32

Open ChildishGiant opened 7 years ago

ChildishGiant commented 7 years ago

thatrobotdev commented 7 years ago

I can confirm this with https://chingu-coders.github.io/owl-24/. I'm going to look in the code to see if I can do anything (might not be able to do anything, since I am pretty new with JS)

thatrobotdev commented 7 years ago

Ok I think I can pinpoint this issue down to this line of code: <svg width="80" height="80" This is definitely where the hitbox oversteps.

NNTin commented 6 years ago

https://nntin.github.io/discord-logo/

I've come up with a solution but it is not an elegant one. I applied the link to the path element that has the shape of a triangle. Disabled pointer events on the svg element and re-enabled pointer events on the triangle.

06.01.2018 - edit: https://jsfiddle.net/hgjrrt5k/