Adds clip-path for clickable area

tholman / github-corners

A fresher "Fork me on GitHub" callout.

http://tholman.com/github-corners

MIT License

4.93k stars 195 forks source link

Adds clip-path for clickable area #52

Closed Nick-Gabe closed 1 year ago

Nick-Gabe commented 1 year ago

The github corner clickable area was previosly a square, which would trigger the animation even with the mouse not directly over the svg. With this PR it clips the svg to fit its appearance, therefore only being clickable and hoverable inside the svg itself.

Video comparing before and after:

https://user-images.githubusercontent.com/42651514/197653769-2a6bca1e-5d00-4fd4-95ad-06256722d89d.mp4

munierujp commented 1 year ago

@tholman Could you please merge this PR?

tholman commented 1 year ago

Sorry, I been stacked. Ya! Looks good

tholman commented 1 year ago

Will merge to site when i grab a minute