search

tholo / pytest-flake8

pytest plugin to run flake8
Other
117 stars 47 forks source link

No make_notifier with latest flake8 #56

Closed jaraco closed 5 years ago

jaraco commented 5 years ago

I had a project that was pinned to pycqa/flake8 master. When I ran the tests recently, they started failing with this error:

.tox/python/lib/python3.7/site-packages/pluggy/hooks.py:284: in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
.tox/python/lib/python3.7/site-packages/pluggy/manager.py:68: in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
.tox/python/lib/python3.7/site-packages/pluggy/manager.py:62: in <lambda>
    firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
.tox/python/lib/python3.7/site-packages/_pytest/runner.py:123: in pytest_runtest_call
    item.runtest()
.tox/python/lib/python3.7/site-packages/pytest_flake8.py:117: in runtest
    self.statistics)
.tox/python/lib/python3.7/site-packages/py/_io/capture.py:150: in call
    res = func(*args, **kwargs)
.tox/python/lib/python3.7/site-packages/pytest_flake8.py:190: in check_file
    app.make_notifier()
E   AttributeError: 'Application' object has no attribute 'make_notifier'

Removing the dependency on master and allowing the pytest-flake8 dependency to designate flake8 corrected the issue.

But I wanted to report this issue here in case I've stumbled on a bug that might emerge with the next release of flake8. Feel free to investigate or close as you see fit.

sambrightman commented 5 years ago

This just hit us with flake8 3.7.1 (vs 3.6.0 working).

jwegger commented 5 years ago

Hit us too, seems to have changed in v3.7.0 which was released some hours ago. Release note says: