search

tholo / pytest-flake8

pytest plugin to run flake8
Other
117 stars 47 forks source link

Pin flake8 version before 3.7 #58

Closed cblegare closed 5 years ago

cblegare commented 5 years ago

Workaround tholo/pytest-flake8#56

AttributeError: 'Application' object has no attribute 'make_notifier'

introduced by https://gitlab.com/pycqa/flake8/merge_requests/274

jirikuncar commented 5 years ago

I have added a simple check in #59 so we can use pytest-flake8 with any version of flake8.

tholo commented 5 years ago

Fixed differently by checking for existence of make_notifier

cblegare commented 5 years ago

Thank you guys, I agree my fix was a bit lazy