search

tholo / pytest-flake8

pytest plugin to run flake8
Other
117 stars 47 forks source link

Fix pytest deprecation warning from_parent #64

Closed MRigal closed 4 years ago

MRigal commented 4 years ago

Fixes #63

MRigal commented 4 years ago

Wow @tholo pytest reacted differently than in my tests, it seems broken. Sorry, I couldn't find a link to the test results of CI until you merged it, I'm gonna have a look now

tholo commented 4 years ago

That’s fine, I have it fixed and will be pushing very shortly.

Thorsten

On Apr 23, 2020, at 11:46, Matthieu Rigal notifications@github.com wrote:

Wow @tholo https://github.com/tholo pytest reacted differently than in my tests, it seems broken. Sorry, I couldn't find a link to the test results of CI until you merged it, I'm gonna have a look now

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tholo/pytest-flake8/pull/64#issuecomment-618585683, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABIUP2YVJHBUMOJME2KL4DROCEJNANCNFSM4MO6QTFQ.

MRigal commented 4 years ago

OK, I was not able to run the tests properly locally. Using tox it actually used the pip version and reproduced the warning (which I had overseen before) and invoking pytest directly after pip install -e . I got other errors...

MRigal commented 4 years ago

Sorry for the mess @tholo

MRigal commented 4 years ago

Thanks for fixing it @tholo ! Thanks also for the quick release on Pypi! However I noticed you haven't pushed a Tag/Release here on Github, you might want to do that in order to keep track of the versions here :-)

tholo commented 4 years ago

Oops! Pushed the changes but not the tag… Fixed that.

On Apr 23, 2020, at 13:32, Matthieu Rigal notifications@github.com wrote:

Thanks for fixing it @tholo https://github.com/tholo ! Thanks also for the quick release on Pypi! However I noticed you haven't pushed a Tag/Release here on Github, you might want to do that in order to keep track of the versions here :-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tholo/pytest-flake8/pull/64#issuecomment-618651574, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABIUP7BFIEXJMRJXHMCD6LROCQVPANCNFSM4MO6QTFQ.