search

tholoien / empiriciSN

Generate realistic parameters for a SN given host galaxy observations based on empirical correlations from SN datasets
MIT License
2 stars 4 forks source link

XDGMM Class #15

Closed tholoien closed 8 years ago

tholoien commented 8 years ago

Create XDGMM class that incorporates the astroML and Bovy et al. fitting methods and is a wrapper for the scikit-learn Estimator class so that it can be used with the scikit-learn machine learning (cross validation) methods.

tholoien commented 8 years ago

This is under construction and can be found here

drphilmarshall commented 8 years ago

Excellent! At what point will you consider this issue closeable?

tholoien commented 8 years ago

I am going to close it when I have a class that can be used for the scikit-learn methods, has correct conditioning, and implements at least one of the methods for XDGMM. All that is left at this point is fixing up the conditioning.

drphilmarshall commented 8 years ago

Oh cool - really glad that the scikit-learn machinery now works! Can you push a simple Demo.ipynb notebook that shows this in action?

On Fri, Aug 12, 2016 at 11:31 AM, Tom Holoien notifications@github.com wrote:

I am going to close it when I have a class that can be used for the scikit-learn methods, has correct conditioning, and implements at least one of the methods for XDGMM. All that is left at this point is fixing up the conditioning.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tholoien/empiriciSN/issues/15#issuecomment-239524926, or mute the thread https://github.com/notifications/unsubscribe-auth/AArY99h2B5SdHeHwqhi58nWqSukvVLwnks5qfLwZgaJpZM4JjTds .

tholoien commented 8 years ago

XDGMM is up and running. Closing this.

drphilmarshall commented 8 years ago

Yesss! Nice work, Tom :-)