Closed drphilmarshall closed 8 years ago
Oops, forgot to update the tests... BTW my version of the notebook is here. I edited the text too, to make it terser. Also I found that the distributions of radial positions are not significantly different - try a few different training /test splits and you'll see.
Alright! I think my work is done. Travis now runs the notebook as well as the unit tests, check out the .travis.yml file :-) Reproducible astronomy!
Here are my notes!
pylint
so you get warnings about your code - I started doing this year and am enjoying it! I love standards.Empiricist
, calling it a "worker" class. This is because we are asking it to perform functions for us - so it is modeling a person doing calculations. The method names now make sense: "Empiricist! get_SN!"get_local_SB
method belongs in theEmpiricist
class - the reason you needed it was because the currentEmpiricist.get_data
method is not modular enough. I did not do this refactoring but will issue it.get_SN
so that the output is always(n_SN, 3)
in shape, even ifn_SN=1