search

thom311 / libnl

Netlink Library Suite
GNU Lesser General Public License v2.1
419 stars 311 forks source link

Is the comment for nl_nh_group_info correct? #356

Closed irino closed 1 year ago

irino commented 1 year ago

When I read PR #332, I found comments that seem incorrect https://github.com/thom311/libnl/blob/4c39a2ce1b379c4caa8118ba544b53c9bdb3b687/include/netlink/route/nh.h#L19C25-L19C25

typedef struct nl_nh_group_info {
    uint32_t nh_id; /*!< VLAN number */
    uint8_t weight; /*!< VLAN QOS value */
} nl_nh_group_info_t;

I think the comments should be 

typedef struct nl_nh_group_info {
    uint32_t nh_id; /*!< nexthop id */
    uint8_t weight; /*!< weight in nexthop group*/
} nl_nh_group_info_t;
thom311 commented 1 year ago

you are right, looks like a copy+paste error. Should be fixed :)

thom311 commented 1 year ago

fixed by https://github.com/thom311/libnl/commit/74bffbf6181f9d5afc722ce71c9cc9e48d519dbc

Thanks!!