search

thom4parisot / crx

A node.js command line app for packing Google Chrome extensions.
https://npmjs.com/crx
MIT License
516 stars 71 forks source link

Some extensions need to include .crx files #131

Open kennynguyeenx opened 3 years ago

kennynguyeenx commented 3 years ago

I need to pack one extension which include another .crx files but for now they are ignored in code and we don't have any options to configure for it

For now, I have hard patched the module in node_modules folder but this is not ideal.

https://github.com/oncletom/crx/blob/master/src/index.js#L160

ignore: ["*.pem", ".git", "*.crx"] => ignore: ["*.pem", ".git"]

thom4parisot commented 3 years ago

Sorry for lagging and making you wait. And thanks for reporting this issue!

It totally makes sense to me, I’m thinking to make the ignore bit an option.

And maybe in the future to rework the API so the file list becomes a mandatory argument.

If you feel like proposing a fix you’re welcome, otherwise I’ll do it when I get my computer back from repair.