thom4parisot / grunt-crx

Grunt task used to package private Chrome Extensions.
https://npmjs.com/grunt-crx
MIT License
118 stars 21 forks source link

privateKey option can't be set in the "options" object #45

Closed AoDev closed 9 years ago

AoDev commented 9 years ago

Hello,

This works:

    crx: {
      example: {
        options: {
          baseURL: 'http://...'
        },
        privateKey: 'key/chrome.pem',
        src: dir,
        dest: dir,
        filename: 'example.crx'
      }
    },

This does not work: (and your docs are like this)

    crx: {
      example: {
        options: {
          baseURL: 'http://...',
          privateKey: 'key/chrome.pem',
        },
        src: dir,
        dest: dir,
        filename: 'example.crx'
      }
    },
adamjakab commented 9 years ago

I confirm the docs bug.

thom4parisot commented 9 years ago

Thanks guys. Which version of grunt-crx do you use? The actual master/1.x branch is not tagged as latest on npm https://www.npmjs.org/package/grunt-crx because of #44 (although npm advertises the 1.x README).

If you use grunt-crx < 1.0.0, it is the expected behaviour. If you use grunt-crx >= 1.0.0, it is definitely a bug.

Sorry for the confusion.

AoDev commented 9 years ago

It's 0.3.4 for me.

84564221 commented 9 years ago

This bug drove me crazy

mbernath commented 9 years ago

Hi, I can also confirm the bug using 0.3.4.

jpalomar commented 9 years ago

i think this bug is resolved in the pull request: https://github.com/oncletom/grunt-crx/pull/47

thom4parisot commented 9 years ago

Hello guys!

The last one did not work but #47 fixed it :-) The v1 branch is not yet the latest one in term of npm because of a critical bug (files are not excluded and it can be a severe security breach).

npm install --save grunt-crx // installs grunt-crx@0.3.x
npm install --save grunt-crx@beta // installs grunt-crx@1.x

Type npm info grunt-crx for up to date npm tags info.